wikimedia-gadgets / shortdesc-helper

Gadget on the English Wikipedia.
8 stars 4 forks source link

merge Shortdesc-helper.css and Shortdesc-helper-pagestyles-vector.css? #9

Closed NovemLinguae closed 1 year ago

NovemLinguae commented 1 year ago

All the styles in the file Shortdesc-helper-pagestyles-vector.css contain .skin-vector, so it should be safe to merge it with the file Shortdesc-helper.css. Both files are tiny, so it may not be worth the increased complexity of having the files separated, and having two different gadgets. Performance issues should be negligible.

image
mmiyer commented 1 year ago

Sorry no the point of this being separate is that a css only gadget is page blocking but a css in a JavaScript gadget is loaded later. Doing it this way avoids a FOUC where the short description jumps around.