wikimedia-gadgets / twinkle

The English Wikipedia twinkle javascript helper
http://en.wikipedia.org/wiki/Wikipedia:Twinkle
Other
137 stars 153 forks source link

Talkback improperly normalizes links to DYK discussions #1346

Open enterprisey opened 3 years ago

enterprisey commented 3 years ago

In 3825f47, normalizeTalkbackPage seems to only allow links to all talk namespaces and the Wikipedia namespace. Unfortunately, DYK discussions occur in the Template namespace, so this change makes it impossible to use the talkback functionality to link to a DYK discussion.

Potential solutions:

credit to Narutolovehinata5 for originally pointing this out

Amorymeltzer commented 3 years ago

Oof, thanks! For now, I've added templatespace in #1348, as well as a tooltip note.

Maybe it'd be better to just allow specific places like T:DYK subpages, but I'm trying to think if there are any others like that. I thought POTD stuff, but maybe not. I don't think the entire project will move their discussions to a different namespace, but I do think that'd be better.

siddharthvp commented 3 years ago

Or we could do without overreaching normalisations like this.

Amorymeltzer commented 3 years ago

I suppose folks sometimes do discussions in userspace as well. I'm fine with just 0->1; it's nonobvious with a default to 3, but still possible. There's some discontinuity with defaulting a no-namespace entry to usertalk space, which I think is still valuable.

siddharthvp commented 3 years ago

Let's make it clear using the label and/or the placeholder that a talk page is to be entered. No need for any normalisation.

enterprisey commented 3 years ago

Thanks for the fast response!

Alternative route: display a tooltip or span saying "this is a content namespace! are you sure you want to link to this page instead of its talk page" when appropriate, and then perform no automatic normalization

Amorymeltzer commented 3 years ago

@enterprisey Some sort of alert, like is done elsewhere?