XfD module should be disabled if you are partially blocked from the project namespace

wikimedia-gadgets / twinkle

The English Wikipedia twinkle javascript helper

http://en.wikipedia.org/wiki/Wikipedia:Twinkle

Other

138 stars 152 forks source link

XfD module should be disabled if you are partially blocked from the project namespace #1403

Open pppery opened 3 years ago

pppery commented 3 years ago

... or else things like this happen, where Twinkle fails to post the nomination due to the partial block, but still notifies the creator and still tries to tag the page (which also failed because the user was blocked from editing that page and resulted in an edit request; this part isn't technically broken)

siddharthvp commented 3 years ago

The proper fix is that all those actions should wait for the discussion page creation to succeed first. This has already been fixed in twinkle-enwiki repo (see https://github.com/wikimedia-gadgets/twinkle-enwiki/blob/5bb17e243f9404e9a8722d0f137ac2a6eb14bd81/src/xfd.ts#L481-L486 - the format is this.tm.add(TASK, [...DEPENDENT TASKS...]) ).