wikimedia-gadgets / twinkle

The English Wikipedia twinkle javascript helper
http://en.wikipedia.org/wiki/Wikipedia:Twinkle
Other
135 stars 148 forks source link

Pros and cons of switching to twinkle-core? #1514

Open NovemLinguae opened 2 years ago

NovemLinguae commented 2 years ago

I haven't installed it and tested it out yet, but wanted to explore the idea of switching to twinkle-core and twinkle-enwiki and see if it's something that should be on our radar.

Theoretically there are many technical debt benefits to not having two repositories, working in OOP and TypeScript, and supporting other wikis and internationalization.

In terms of GUI, features, etc, how identical or different is twinkle-core compared to this Twinkle repository? Also, is it stable and reasonably bug-free?

siddharthvp commented 2 years ago

In terms of GUI, features, etc, how identical or different is twinkle-core compared to this Twinkle repository? Also, is it stable and reasonably bug-free?

It is identical, or at least meant to be identical. There are very few differences – most significant I believe is that the tag module doesn't support alphabetical mode. An extra mode which is mostly unused seemed like too much to implement while supporting i18n/l10n.

Bugs can be present – it is not very stable as I don't think it's being used in production anywhere. But on the bright side, it has an integration test suite that we've never had here.

The pros:

The cons:

Parts of twinkle-core still use english / enwiki specific code – but those are a not a problem for deploying on enwiki. They needs to be properly i18n-ised which can be looked into later.

Overall, I don't expect any other wiki to use twinkle-core if it isn't being used on enwiki – other wikis tend to follow what enwiki does.

NovemLinguae commented 2 years ago

Is there a compiled version of twinkle-core/twinkle-enwiki on enwiki yet that people can load up as a user script? Even if it's not a gadget, in userspace, etc.

I think that's the first step to switching over.

We need to have an opt-in beta test advertised at [[WT:TWINKLE]] so people can try it out, report bugs, report differences between the two Twinkles, etc.

There's a bit of a time crunch... the two Twinkles are getting more and more out of sync. If we're going to explore switching, we should start the process soon.