siddharthvp
commented
2 years ago https://github.com/wikimedia-gadgets/twinkle-enwiki/tree/master/tests/integration
Yes, why not. But I'd more prefer if we could migrate to use twinkle-enwiki itself :)
Open NovemLinguae opened 2 years ago
siddharthvp
commented
2 years ago https://github.com/wikimedia-gadgets/twinkle-enwiki/tree/master/tests/integration
Yes, why not. But I'd more prefer if we could migrate to use twinkle-enwiki itself :)
NovemLinguae
commented
2 years ago I think I have a ticket to explore the idea of migrating to twinkle-enwiki. #1514. I'll have to carve out some time to install it and play around with it.
Seems like you paid a bunch of technical debt by converting everything to classes and adding integration tests. Likely makes sense to switch to it, before things get too out of sync.
Maybe we can make it easy to install somehow, and people can switch to it as part of a beta test that we advertise at [[WT:TWINKLE]], to help us start stomping out bugs.
NovemLinguae
commented
2 years ago Related #1384
Hey @siddharthvp. I notice you wrote a bunch of integration tests over at https://github.com/wikimedia-gadgets/twinkle-starter/tree/master/tests/integration. Would those be easy to port over to this repo?
Would be nice to have some integration tests for all the major workflows. And also to write tests whenever we squash a bug, such as today's #1565. Could write a test that just clicks the preview button for FFD and makes sure it doesn't throw an error.