search

wikimedia-gadgets / twinkle

The English Wikipedia twinkle javascript helper
http://en.wikipedia.org/wiki/Wikipedia:Twinkle
Other
135 stars 151 forks source link

Twinkle doesn't check edit conflict in PROD and CSD module #172

Open lsmll opened 11 years ago

lsmll commented 11 years ago

Just now I PROD'ed the article Pootis,but there is a edit conflict and the article was redirected to Team Fortress 2.To my surprise,Twinkle put a PROD tag on Team Fortress 2.It seems TW doesn't check edit conflict before putting a PROD tag.Later it was confirmed by another user on WT:TW that this bug also exists in CSD module.

To be exact: 1.I go to article X and use Twinkle to CSD/PROD it. 2.Meanwhile,someone else has changed article X into a redirect to article Y. 3.Twinkle tags Y with CSD/PROD template,and sent a notice of CSD/PROD to the creator of X.

I think Twinkle should abort CSD/PROD if there is a edit conflict.Please fix it.

atlight commented 11 years ago

I can confirm that this is an issue. I'll investigate it.

atlight commented 11 years ago

I can't seem to get this to happen anymore. I wonder if it is still a problem?

atlight commented 10 years ago

This is not strictly an "edit conflict" situation, IIRC. At no time during steps 1 to 3 is an edit conflict arising. It is simply a result of Twinkle not doing what the user expected.

Fixing #10 would fix this.

siddharthvp commented 4 years ago

I think solving the general case of this problem -- aborting the action if page was edited b/w the time of user loading the page in the browser and the time of page being internally loaded by morebits.wiki.page -- would be a regression as in most cases, a few edits made to the page in a very short duration wouldn't affect the user's assessment of the page being deletion-worthy.

On the other hand, the specific case of the page being moved or redirected to another page -- which is example cited by in the issue -- is worth solving, and can be done as described in https://github.com/azatoth/twinkle/issues/379#issuecomment-548321410.