search

wikimedia-gadgets / twinkle

The English Wikipedia twinkle javascript helper
http://en.wikipedia.org/wiki/Wikipedia:Twinkle
Other
135 stars 147 forks source link

Handle abuse filter warnings/errors #182

Open Amalthea opened 10 years ago

Amalthea commented 10 years ago

An abuse filter warning is currently an irrecoverable error. API will return something like:

<?xml version="1.0"?><api><edit code="abusefilter-warning-codespill" info="Hit AbuseFilter: Extraneous formatting" warning="&lt;table [...]" result="Failure" /></api>

(warning HTML truncated).

I imagine Twinkle should display that warning and allow the user to try again (not sure what the mechanism for that is)

atlight commented 10 years ago

Hmm, I'll have a play with this.

atlight commented 10 years ago

See also https://bugzilla.wikimedia.org/show_bug.cgi?id=55460.

atlight commented 10 years ago

The only problem with that commit is that all is lost when an AbuseFilter warning is hit. The edit should be retried automatically (as happens for edit conflicts) if the editor chooses to retry. The problem lies in providing the choice to the user. I seem to remember that AzaToth is quite keen to see the Status system overhauled, and some kind of status-based prompt could be implemented as part of any such future overhaul.

atlight commented 10 years ago

Unassigning myself for now, as I don't plan to do any more work on this for the time being.