search

wikimedia-gadgets / twinkle

The English Wikipedia twinkle javascript helper
http://en.wikipedia.org/wiki/Wikipedia:Twinkle
Other
138 stars 152 forks source link

TypeError: undefined is not an object (evaluating 'Twinkle.welcome.normal') #2093

Open jdlrobson opened 2 hours ago

jdlrobson commented 2 hours ago

Any idea what might be causing this error in production? 1,089 errors in last 7 days

I was unable to replicate it on https://en.m.wikipedia.org/wiki/Esther_Hart_(Titanic_survivor) but all the errors come from mobile domain with the following gadgets enabled:

Twinkle,morebits,select2,geonotice,defaultsummaries,HotCat,afchelper,switcher,script-installer,Twinkle-pagestyles

and the stack trace is pretty useless but flags the offending function as:

at twinklewelcome

Presumably when that method is executed, Twinkle.welcome.normal doesn't exist ?

NovemLinguae commented 1 hour ago

I did a deploy that fixed some bugs 3 days ago. https://github.com/wikimedia-gadgets/twinkle/commit/e7d4c6ca4e3969a398a7d6a6e6e850d66b8b5755 Any chance the errors stopped 3 days ago?

NovemLinguae commented 1 hour ago

I renamed some of that stuff from friendlywelcome to twinklewelcome about 2 weeks ago. https://github.com/NovemLinguae/twinkle/commit/35efcd882b15e9c603a3489e812817113f004a25

Do we have the exact date the errors started and ended (if they ended), so I can track down which deploy is the cause?

Also, any suggestions for mw.log type code to add to get us better info?

nardog commented 1 hour ago

Might have to do with TwinkleMobile.

NovemLinguae commented 1 hour ago

Nice catch. Yeah regular Twinkle doesn't even work with Minerva. I should have thought of that. I've pinged the TwinkleMobile maintainer onwiki: https://en.wikipedia.org/wiki/User_talk:Plantaest/TwinkleMobile#Changes_to_upstream_Twinkle