wikimedia-gadgets / twinkle

The English Wikipedia twinkle javascript helper
http://en.wikipedia.org/wiki/Wikipedia:Twinkle
Other
135 stars 147 forks source link

Better handling of IP ranges on Special:Contribs #775

Open Amorymeltzer opened 4 years ago

Amorymeltzer commented 4 years ago

Some discussion at meta with @MusikAnimal, but the underlying issue is that wgRelevantUserName does not exist for valid IP ranges; see T206954 and #476 (and MusikAnimal/MoreMenu@13d46f8 and T211910).

Modules that Twinkle displays on contribs for IPs are arv, block, talkback, warn, and welcome, but right now none of those show up for valid ranges since they all rely on wgRelevantUserName. That's good for warn and welcome — we don't want to warn or welcome ranges — but, at least in theory, some of the functions of arv and block should be allowed, if somewhat broken. In particular:

In the end, this is just a PITA that will complicate and obfuscate the code a fair bit. Of course, depending on if and how T206954 is resolved, we'll want to exclude a number of these modules and their functions. Largely done in #1266

Amorymeltzer commented 3 years ago

Should be doable starting in January sometime

Amorymeltzer commented 3 years ago

In theory #1266 did all this, but since T206954 still isn't merged/live, and #1296 is outstanding, gonna keep this open to track ongoing/future work needed.