search

wikimedia / WikiContrib

A tool for Wikimedia community members to visualize their technical contributions
https://wikicontrib.toolforge.org
MIT License
23 stars 32 forks source link

Fixed #131 #162

Closed shivanigangadharan closed 4 years ago

shivanigangadharan commented 4 years ago

@srish The blocks overflowed when the screen width was above 1456px. So I created a media query for the same and it looks good on laptop view now. Auto-resizing is yet to be done though, still trying to figure that out. Hope this much works well, let me know how it looks on your screen, thanks!

rammanoj commented 4 years ago

Please check this

shivanigangadharan commented 4 years ago

Hi! I just tested your changes. For resolution with width < 600 px, I still see the overflow issue in laptop view: Could you take a re-look?

I just checked, yes on resizing it does overflow but as @rammanoj mentioned, I think we need to refresh it in order to view the correct dimensions. Also as you mentioned, I tried the screen for a width<600px. In the picture below, I have kept the width as 420px, then it looks good after refreshing. Let me know if the problem still persists, thanks.

image

srish commented 4 years ago

Thanks, @shivanigangadharan, for these changes. About the overflow issue in general, I still think that the blocks should re-adjust without having to do the refresh on the screen. But, your changes to fix the overflow on screens > 1456px is a helpful step.

shivanigangadharan commented 4 years ago

Thanks, @shivanigangadharan, for these changes. About the overflow issue in general, I still think that the blocks should re-adjust without having to do the refresh on the screen. But, your changes to fix the overflow on screens > 1456px is a helpful step.

Right, I agree with that too. Will update when I arrive at a solution for that too, till then thanks a lot for all your guidance and help. It was great to work on this issue! :)