search

wikimedia / WikiContrib

A tool for Wikimedia community members to visualize their technical contributions
https://wikicontrib.toolforge.org
MIT License
23 stars 32 forks source link

Reverted #187 and Fixed #184 #195

Closed NdibeRaymond closed 4 years ago

NdibeRaymond commented 4 years ago

removed window.history.push from activity.js as it is the cause of issue #190 and fixed issue #184

srish commented 4 years ago

@NdibeRaymond After these changes, do you still see the issue that was raised in https://github.com/wikimedia/WikiContrib/issues/184?

NdibeRaymond commented 4 years ago

@NdibeRaymond After these changes, do you still see the issue that was raised in #184?

yes @srish , this pull only reverses the change made by #187 because of the bug it introduced

srish commented 4 years ago

@NdibeRaymond Hmm, so ideally, the PR you submitted also contains the solution for https://github.com/wikimedia/WikiContrib/issues/184. I suggest that we consider incorporating a fix for 184 in this PR.

NdibeRaymond commented 4 years ago

@NdibeRaymond Hmm, so ideally, the PR you submitted also contains the solution for #184. I suggest that we consider incorporating a fix for 184 in this PR.

ok @srish . will look into it

NdibeRaymond commented 4 years ago

@srish and @rammanoj I added a fix for issue #184 as srish suggested. please review

rammanoj commented 4 years ago

@NdibeRaymond The change is good. It is working fine :) Thanks for the PR.