search

wikimedia / WikiContrib

A tool for Wikimedia community members to visualize their technical contributions
https://wikicontrib.toolforge.org
MIT License
23 stars 32 forks source link

Added 'go to top' functionality #209

Closed NdibeRaymond closed 4 years ago

NdibeRaymond commented 4 years ago

This is an improvement over @harshika18 's PR. I removed the unnecessary setInterval delay, generally reduced the line of code and added @rammanoj 's icon recommendation

issue fixed: #180

go_to_top

rammanoj commented 4 years ago

@NdibeRaymond I think whenever you press the button it need to go to the top slowly (i.e introduce some delay). Can you also check if the color of the button matches with view filters/update button color ? you are also welcomed to change the styles of button :)

NdibeRaymond commented 4 years ago

@NdibeRaymond I think whenever you press the button it need to go to the top slowly (i.e introduce some delay). Can you also check if the color of the button matches with view filters/update button color ? you are also welcomed to change the styles of button :)

ok

NdibeRaymond commented 4 years ago

I made the changes you requested @rammanoj. Review when you have time

rammanoj commented 4 years ago

+1 good to go. Thanks @NdibeRaymond and @harshika18 for working on the feature