search

wikimedia / WikiContrib

A tool for Wikimedia community members to visualize their technical contributions
https://wikicontrib.toolforge.org
MIT License
23 stars 32 forks source link

WikiContrib violates user privacy by loading third party content from Cloudflare #279

Open aklapper opened 2 years ago

aklapper commented 2 years ago

https://wikicontrib.toolforge.org/ loads <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.4.1/semantic.min.css">. This is a third-party privacy violation.

It's more concerning now that this tool is linked from the Wikimedia Developer Portal.

Please use https://tools-static.wmflabs.org/cdnjs/ajax/libs/semantic-ui/2.4.1/semantic.min.css instead and deploy.

See also https://phabricator.wikimedia.org/T231312

srish commented 2 years ago

@NdibeRaymond You still have access to this tool on Toolforge right? I'd let you take on this.

aklapper commented 2 years ago

https://toolsadmin.wikimedia.org/tools/id/wikicontrib lists four maintainers :)

NdibeRaymond commented 2 years ago

@NdibeRaymond You still have access to this tool on Toolforge right? I'd let you take on this.

yes I still do @srish. I will fix this issue

NdibeRaymond commented 2 years ago

https://wikicontrib.toolforge.org/ loads <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.4.1/semantic.min.css">. This is a third-party privacy violation.

It's more concerning now that this tool is linked from the Wikimedia Developer Portal.

Please use https://tools-static.wmflabs.org/cdnjs/ajax/libs/semantic-ui/2.4.1/semantic.min.css instead and deploy.

See also https://phabricator.wikimedia.org/T231312

thanks for making this known @aklapper . I will fix this ASAP

wkyoshida commented 1 year ago

Hi!

Out of curiosity - I was wondering if this issue has now been resolved with https://github.com/wikimedia/WikiContrib/pull/280 - would that be right?

aklapper commented 1 year ago

That's a good question for @NdibeRaymond - if this is fixed, please close this ticket

NdibeRaymond commented 1 year ago

Yeaaa forgot to close this, closing now

aklapper commented 9 months ago

This is still an issue when I go to https://wikicontrib.toolforge.org/ - how was this resolved? If this was resolved, do you plan to deploy the changes?

aklapper commented 7 months ago

@NdibeRaymond This is still an issue when I go to https://wikicontrib.toolforge.org/ - how was this resolved? If this was resolved, do you plan to deploy the changes?