search

wikimedia / composer-merge-plugin

Merge one or more additional composer.json files at Composer runtime
MIT License
934 stars 159 forks source link

Add support for passing original command-line options to installer #169

Open mxr576 opened 6 years ago

mxr576 commented 6 years ago

Merge plugin did not respected --prefer-lowest option so highest-lowest testing could not be achieved with it. This PR fixes this problem and also fixes some others:

mxr576 commented 6 years ago

Can somebody take a look at the test build in the Travis CI who has admin right? Test jobs were not even started.

Maybe @bd808?

mxr576 commented 6 years ago

Hey, is there anyone here who can review this PR?

hussainweb commented 5 years ago

Thanks for this. I found this PR when looking for a fix for --ignore-platform-reqs. I am going to pull in this as a patch and see if it works.

ro0NL commented 5 years ago

ping :D forwarding --no-suggest would be :100:

mxr576 commented 5 years ago

ping @bd808, you are the maintainer, aren't you?

christoph-kluge commented 3 years ago

Is this PR ongoing or dead? I'm in need of --ignore-platform-reqs.

mxr576 commented 3 years ago

It is dead on my part, someone can take over. We stopped using the merge plugin because it proved to be a bottleneck several times. We rather rely on OTTB Composer features, e.g.: use path repositories on the project level to register dependencies of custom components when needed; and we developed our own upstream Composer repository for shared components. AFAIK, this covers everything that anyone used/using the merge plugin. It was a great tool back in the days but personally, I do not think it is necessary in 2021.

christoph-kluge commented 3 years ago

Thanks for the update. This was very helpful. After re-evaluating our use-case we also decided to drop this.

leymannx commented 1 year ago

@reedy you the only maintainer left? This PR needs some love. 💚

If I run composer create-project --ignore-platform-reqs on a project that requires wikimedia/composer-merge-plugin and has "merge-plugin"-"include" files configured the MergePlugin will not respect the --ignore-platform-reqs and might fail while running the built-in update command.

leymannx commented 1 year ago

We probably should start a new MR for it to work around the conflicts AND make it respect COMPOSER_IGNORE_PLATFORM_REQS=1 as well.