wikimedia / composer-merge-plugin

Merge one or more additional composer.json files at Composer runtime
MIT License
934 stars 159 forks source link

Fix and re-enable IRC notifications #201

Closed reedy closed 3 years ago

reedy commented 3 years ago

There's a few minor issues

[19:39:19] --> wikimedia-github (~wikimedia@40.70.200.114) has joined #wikimedia-dev
[19:39:19] <wikimedia-github> wikimedia/composer-merge-plugin#476090360 ( - 6415d88441c6873cb1f6dc5c199a8e638fe23752 reedy): Migrate to GitHub Actions - https://github.com/wikimedia/composer-merge-plugin/actions/runs/476090360
[19:39:19] <wikimedia-github>  
[19:39:19] <-- wikimedia-github (~wikimedia@40.70.200.114) has left #wikimedia-dev
[19:39:26] --> wikimedia-github (~wikimedia@52.177.186.83) has joined #wikimedia-dev
[19:39:26] <wikimedia-github> wikimedia/composer-merge-plugin#476090360 ( - 6415d88441c6873cb1f6dc5c199a8e638fe23752 reedy): Migrate to GitHub Actions - https://github.com/wikimedia/composer-merge-plugin/actions/runs/476090360
[19:39:26] <wikimedia-github>  
[19:39:26] <-- wikimedia-github (~wikimedia@52.177.186.83) has left #wikimedia-dev
[19:39:33] --> wikimedia-github (~wikimedia@104.209.159.76) has joined #wikimedia-dev
[19:39:33] <wikimedia-github> wikimedia/composer-merge-plugin#476090360 ( - 6415d88441c6873cb1f6dc5c199a8e638fe23752 reedy): Migrate to GitHub Actions - https://github.com/wikimedia/composer-merge-plugin/actions/runs/476090360
[19:39:33] <wikimedia-github>  
[19:39:33] <-- wikimedia-github (~wikimedia@104.209.159.76) has left #wikimedia-dev
[19:39:40] --> wikimedia-github (~wikimedia@52.252.6.67) has joined #wikimedia-dev
[19:39:40] <wikimedia-github> wikimedia/composer-merge-plugin#476090360 ( - 6415d88441c6873cb1f6dc5c199a8e638fe23752 reedy): Migrate to GitHub Actions - https://github.com/wikimedia/composer-merge-plugin/actions/runs/476090360
[19:39:40] <wikimedia-github>  
[19:39:40] <-- wikimedia-github (~wikimedia@52.252.6.67) has left #wikimedia-dev
reedy commented 3 years ago

${{ github.base_ref }} seems to result in no output

https://docs.github.com/en/free-pro-team@latest/actions/reference/context-and-expression-syntax-for-github-actions

For both github.head_ref and github.base_ref

This property is only available when the event that triggers a workflow run is a pull_request.

Looks like github.ref will do what we want

The branch or tag ref that triggered the workflow run. For branches this in the format refs/heads/, and for tags it is refs/tags/.

reedy commented 3 years ago

Seems https://github.com/wikimedia/composer-merge-plugin/commit/d854a2143423b02db54194becc421181eae4cd1a probably fixed the "Blank line message sent with just a trailing space"