wikimedia / composer-merge-plugin

Merge one or more additional composer.json files at Composer runtime
MIT License
926 stars 160 forks source link

StabilityFlagsTest::testLowestWins() looks wrong #208

Closed reedy closed 3 years ago

reedy commented 3 years ago

Data provider has duplicate array keys... Parameters to testLowestWins are all unused...

    /**
     * @dataProvider provideLowestWins
     */
    public function testLowestWins($version, $default, $expect)
    {
        $fixture = new StabilityFlags(array(
            'test' => BasePackage::STABILITY_ALPHA,
        ));
        $got = $fixture->extractAll(array(
            'test' => $this->makeLink('@rc')->reveal(),
        ));
        $this->assertSame(BasePackage::STABILITY_ALPHA, $got['test']);
    }

    public function provideLowestWins()
    {
        return array(
            'default' => array(
                '1.0@RC',
                BasePackage::STABILITY_BETA,
                BasePackage::STABILITY_BETA
            ),
            'default' => array(
                '1.0@dev',
                BasePackage::STABILITY_BETA,
                BasePackage::STABILITY_DEV
            ),
        );
    }