Run phan on composer 1.x?

wikimedia / composer-merge-plugin

Merge one or more additional composer.json files at Composer runtime

MIT License

926 stars 160 forks source link

Run phan on composer 1.x? #210

Open reedy opened 3 years ago

reedy commented 3 years ago

Following up on #204... Do we care about running phan against composer 1.x?

It'll add some complexity, and maybe isn't necessary...

mcaskill commented 3 years ago

I'm unfamiliar with Phan, its configuration, and features, but I think we can ignore Composer 1, if that is possible. If it's just as much as pain to ignore it as to support it 🤷‍♂️.

reedy commented 3 years ago

I've basically ignored 1.x in 8a275c46a998ee610ef87323b4d768fe8a722310 with the @phan-suppress-next-line commands.

If we try and run it on 1.x, we end up needing conditional suppression and other fun things.

It's definitely not impossible, it's just more work. And as I mentioned in #212, it's probably not going to be unreasonable to drop 1.x support in the near future anyway..

reedy commented 1 year ago

https://github.com/wikimedia/composer-merge-plugin/issues/243