Remove $that = $this - Githubissues

wikimedia / composer-merge-plugin

Merge one or more additional composer.json files at Composer runtime

MIT License

938 stars 160 forks source link

Open reedy opened 2 years ago

reedy commented 2 years ago

I don't believe that is needed anymore...

himanshu007-creator commented 2 years ago

Hi, i would like to work on this issue

valerio-bozzolan commented 1 year ago

I didn't understand what this issue is about

mcaskill commented 10 months ago

I assume the issue is about the ambiguity of the variable's name $that in MergePluginTest.

For example, $test would better reflect its reference.

Ideally, I think the anonymous functions are already bound to the test controller so there's no need to pass the test to the functions.

When declared in the context of a class, the current class is automatically bound to it, making $this available inside of the function's scope.