search

wikimedia / eslint-plugin-no-jquery

Control allowance of certain jQuery functions, and suggest or autofix alternatives.
MIT License
31 stars 8 forks source link

no-append-html: Check appendTo/prependTo #310

Closed edg2s closed 6 months ago

edg2s commented 6 months ago

One would usually pass an existing DOM node to these methods, but passing an HTML string is supported, so we should check for it.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1ca9c26) 100.00% compared to head (d3698e7) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #310 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 103 103 Lines 608 608 ========================================= Hits 608 608 ``` | [Files](https://app.codecov.io/gh/wikimedia/eslint-plugin-no-jquery/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wikimedia) | Coverage Δ | | |---|---|---| | [src/rules/no-append-html.js](https://app.codecov.io/gh/wikimedia/eslint-plugin-no-jquery/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wikimedia#diff-c3JjL3J1bGVzL25vLWFwcGVuZC1odG1sLmpz) | `100.00% <100.00%> (ø)` | |