search

wikimedia / html-metadata

MetaData html scraper and parser for Node.js (supports Promises and callback style)
MIT License
138 stars 44 forks source link

Add scraping of Highwire Press tags #28

Closed neonowy closed 8 years ago

neonowy commented 8 years ago

Added parseHighwirePress() function to scrap all the Highwire Press tags.

Phabricator issue: https://phabricator.wikimedia.org/T118633

Bug: T118633

mvolz commented 8 years ago

Don't forget to update package.json with your contributor info and also bump the version a la http://semver.org/ !

mvolz commented 8 years ago

minor issue but the functions in exports.metadataFunctions are in alphabetical order :).

mvolz commented 8 years ago

Line 333, 342, minor style issue, this library doesn't chain variables.

mvolz commented 8 years ago

Great job, I think we're almost ready to merge!