search

wikimedia / html-metadata

MetaData html scraper and parser for Node.js (supports Promises and callback style)
MIT License
138 stars 44 forks source link

Add reading in of html "lang" property to html-metadata's parseGeneral method #48

Closed feelfreelinux closed 7 years ago

feelfreelinux commented 7 years ago

I added metadata "lang" attribute support in parserand lang.js test. GCI task @Filip

Bug: T148303

mvolz commented 7 years ago

Looks like you might have forgotten to add the static tests to this PR?

feelfreelinux commented 7 years ago

I fixed it

feelfreelinux commented 7 years ago

I added static.js

mvolz commented 7 years ago

Also, you should also update README.md to include it at the bottom. Also, for the pull request message, even though we're on github, you should still follow gerrit commit message guidelines, see: https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines

For instance, the subject should be declarative (i.e.Adds lang attribute....etc) and the phabricator task should be linked.

Great work!

mvolz commented 7 years ago

Great, thanks!

d00rman commented 7 years ago

Would have been useful to bump the version too, to make it visible to the library's clients