search

wikimedia / html-metadata

MetaData html scraper and parser for Node.js (supports Promises and callback style)
MIT License
165 stars 44 forks source link

Added icon and appleicon metadata #67

Closed SaffatAhmed closed 6 years ago

SaffatAhmed commented 6 years ago

On one of the scraping test, the website was down so it wouldn't pass. On the the test that is expecting an error, I'm not sure how to fix it.

mvolz commented 6 years ago

For the website being down, just do it.skip on the test and I'll fix it later.

On the other test, sorry, the text of the test is a little confusing. It should really say "fails all tests" because it calls parseAll, not parseJsonLD; the turtle errors page should cause parseAll to fail for every method.

However, it's now passing because the general method is now passing, because it's claiming to find appletouch metadata... which it wasn't before. Which means that the method is erroneously passing :). So you need to make sure it causes parseAll to fail.

SaffatAhmed commented 6 years ago

I fixed the tests that I had errors with. Thank you for clarifying the error.

SaffatAhmed commented 6 years ago

The turtle movie json file and small parts of other files used spaces when the majority of the files used tabs. I replaced all the spaces with tabs.