wikimedia / interconnection-wordpress-theme

WordPress theme created for https://diff.wikimedia.org/
GNU General Public License v2.0
3 stars 0 forks source link

772: Fix to force bylines to be LTR direction to avoid problems on RTL langs #10

Closed MiguelAxcar closed 1 year ago

MiguelAxcar commented 1 year ago

This PR intends to force bylines to be LTR oriented, as some errors are being displayed when those bylines are displayed on RTL languages.

Related issue

https://github.com/humanmade/Wikimedia/issues/772

Testing instructions

Access (adjust your local env url) https://wikimediadiff.vipdev.lndo.site/ar/2022/12/06/%D8%A7%D9%84%D8%AA%D8%B5%D9%88%D9%8A%D8%AA-%D9%84%D8%B5%D9%88%D8%AA-%D8%A7%D9%84%D9%85%D8%B9%D8%B1%D9%81%D8%A9-%D8%A7%D9%84%D8%A5%D9%86%D8%B3%D8%A7%D9%86%D9%8A%D9%8E%D9%91%D8%A9-%D9%83%D9%84%D9%87/ and check if byline is being displayed correctly.

MiguelAxcar commented 1 year ago

@kadamwhite I'm pasting a conversation with @goldenapples about this fix.

Than: Do we know that the entry meta is always English? If not, maybe there needs to be a setting in the Customizer to set that.

Miguel: I'm assuming that entry-meta should always be in English, so this mixing of LTR and RTL is expected.

I'm not deploying it to develop for you to decide if we should move forward or not with this solution.

Thanks!

How it's currently looking

image

ckoerner commented 1 year ago
  • we launched with it only showing what’s in the “Biographical Information” guest author field,
  • but the intent was to update that so that it would show the localized bio from the user profile later on

If we use the localized bio from the profile then...

Miguel: I'm assuming that entry-meta should always be in English, so this mixing of LTR and RTL is expected.

This wouldn't be the case in the future as the bio could be in a RTL language. If that's a correct understanding, then let's fix the date for now, and tackle the bigger RTL/localized bio issue as a separate thing.

MiguelAxcar commented 1 year ago

@kadamwhite the solution is working pretty well, and it makes a lot of sense considering that bylines and dates are all written LTR for now, tackling the bigger issue later on :+1:

kadamwhite commented 1 year ago

Thanks for the review, @MiguelAxcar !