Closed kadamwhite closed 4 months ago
Merged to develop
to test build, and it completed correctly: https://github.com/wikimedia/interconnection-wordpress-theme/actions/runs/8990525292/job/24696037305
Inline annotations are working for JS!:
Reverting 59b6170
@goldenapples Oh fun, look at this: https://developer.mozilla.org/en-US/docs/Web/API/Window/event
Window.event
will be the same as an event
function argument, but was deprecated, so the change you flagged here was functionally more correct but will not have changed actual behavior. Explains a lot.
wp-scripts
is getting updates targeted at Node v20, andsass
is included internally within the@wordpress/scripts
package dependencies. This PR updates the Interconnection build to use Node 20 and the latest version of wp-scripts, and assumes thesass
executable will be provided internally by the wp dependency.Then, to address #4 this fixes existing issues with
npm run lint:js
and then_s
theme)