search

wikimedia / jquery.i18n

🌐 jQuery based internationalization library
GNU General Public License v2.0
704 stars 144 forks source link

Update devDependencies packages #214

Closed amire80 closed 4 years ago

amire80 commented 4 years ago

eslint-config-wikimedia: 0.14.1 -> 0.15.3 eslint-plugin-qunit: 4.0.0 -> 4.2.0 grunt-eslint: 22.0.0 -> 23.0.0 jquery: 3.4.0 -> 3.5.1

Nikerabbit commented 4 years ago

Failure might be due to requiring eslint7, which no longer supports node 0.10.x. Some of the packages pull in eslint 7.1, as can be seen in package-lock.json. I think it's grunt-eslint and maybe others.

amire80 commented 4 years ago

Mmmm... And do we need to support this version of node?

Nikerabbit commented 4 years ago

This isn't a node library, so no. I think it's only used for linting/testing. Latest version that Travis needs is sufficient.

amire80 commented 4 years ago

OK, and do you know how to fix it?

Nikerabbit commented 4 years ago

I'd try updating https://github.com/wikimedia/jquery.i18n/blob/master/.travis.yml#L4

amire80 commented 4 years ago

OK, done in https://github.com/wikimedia/jquery.i18n/pull/215

amire80 commented 4 years ago

215 appears to have fixed this issue, but created some others. I'm working on it.