search

wikimedia / jquery.i18n

🌐 jQuery based internationalization library
GNU General Public License v2.0
703 stars 143 forks source link

T278639 | Update fallback chain for jquery.i18n.fallbacks #240

Closed winstonsung closed 1 year ago

winstonsung commented 2 years ago

Update fallback chain for jquery.i18n.fallbacks

This update language fallback chains to mediawiki-core 7609761ab4e

To generate this, use

$ grep -R "fallback =" /path/to/messages/

and format the result. -- https://dev.fandom.com/wiki/MediaWiki:I18n-js/code.js#L-180

Bug: T193566 Bug: T333425 Bug: T254854 Bug: T278639 Bug: T237672 Bug: T137376 Bug: T338416 Bug: T137411 Bug: T245359

Patchsets:

winstonsung commented 1 year ago

(The current patchset is outdated and need to extract and update to new fallback chains.)

winstonsung commented 1 year ago

Updated to mediawiki-core 7609761ab4e .

winstonsung commented 1 year ago

CC:

winstonsung commented 1 year ago

Added bew: https://gerrit.wikimedia.org/r/929150 , Change-Id: Id199cb260668c3a886697ed55790a73079a232b3

winstonsung commented 1 year ago 
Running "qunit" task

Running "qunit:all" (qunit) task
Verifying property qunit.all exists in config...OK
File: [no files]
Options: timeout=5000, inject="/home/runner/work/jquery.i18n/jquery.i18n/node_modules/grunt-contrib-qunit/chrome/bridge.js", urls=["http://localhost:9001/test/index.html"], force=false, console, httpBase=false, summaryOnly=false
>> There was an error with headless chrome
Fatal error: Failed to launch chrome!
Inconsistency detected by ld.so: ../elf/dl-tls.c: 481: _dl_allocate_tls_init: Assertion `listp->slotinfo[cnt].gen <= GL(dl_tls_generation)' failed!

TROUBLESHOOTING: https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md

Error: Process completed with exit code 1.
winstonsung commented 1 year ago

recheck

winstonsung commented 1 year ago

(CC @amire80 )

amire80 commented 1 year ago

I don't think "recheck" works here.

The code looks good to me, but there's probably a repository configuration bug that makes the automatic tests fail. I'll see what I can do to fix it.

winstonsung commented 1 year ago

The code looks good to me, but there's probably a repository configuration bug that makes the automatic tests fail. I'll see what I can do to fix it.

Maybe just re-run the actions?

https://github.com/wikimedia/jquery.i18n/actions/runs/5244139705

Abijeet commented 1 year ago

I closed and reopened the PR in order to re-run the actions again.

winstonsung commented 1 year ago

Oh, CI passed now.