search

wikimedia / mediawiki-gadgets-RTRC

Mirror of https://gerrit.wikimedia.org/g/mediawiki/gadgets/RTRC.
https://meta.wikimedia.org/wiki/RTRC
MIT License
26 stars 11 forks source link

Missing CSS #7

Closed he7d3r closed 11 years ago

he7d3r commented 11 years ago

Today I'm getting a page without formatting when I access: https://pt.wikipedia.org/wiki/User:Krinkle/RTRC?uselang=en missing css

Krinkle commented 11 years ago

I assume you're using the latest master from this repository and not the current stable version?

It is failing because I've removed the importStylesheetURI function call from the javascript code. That was making the gadget hard to maintain since it had a hardcoded link to the css page on meta.wikimedia.org.

Removed it in commit https://github.com/Krinkle/mw-gadget-rtrc/commit/1c704ad72f76df12657258f92e7813d3c68fef6b#L3L1283.

Please add a second import command near where you're loading blob/master/rtrc.js for blob/master/rtrc.css.

mw.loader.load( 'https://raw.github.com/Krinkle/mw-gadget-rtrc/master/src/rtrc.css', 'text/css', true );
mw.loader.load( 'https://raw.github.com/Krinkle/mw-gadget-rtrc/master/src/rtrc.js' );

(untested)

When I update the old gadget on Meta, I'll include it for backwards compatibility. The new gadget I'm preparing on mediawiki.org will simply have it built-in as a separate gadget resource so that it saves an http request.

(mediawiki.org: rtrc.js, rtrc.css – still broken, not ready yet)

he7d3r commented 11 years ago

For some reason, it is not possible to load the CSS from https://raw.github.com/Krinkle/mw-gadget-rtrc/master/src/rtrc.css (maybe it is related to the warning "Resource interpreted as Stylesheet but transferred with MIME type text/plain"?)

he7d3r commented 11 years ago

I tried to make a local copy of the CSS and import that instead: https://pt.wikibooks.org/w/index.php?diff=261054&oldid=261040&uselang=en It kind of worked, but there was some overlap with the vector interface. captura de tela de 2013-08-24 11 05 33

Krinkle commented 11 years ago

I know. I'm in the middle of a rewrite. Latest drafts are in the refactor-ui and refactor-logic branches. Note though that there are several features disabled there while things are being recreated in the new structure.

Best to go back to using the stable version for now. I'll let you know when the rewrite is finished enough to be a testable beta version.

Krinkle commented 11 years ago

The warning is because the GitHub raw mode is not supposed to be used as CDN or execution point but purely to view the source. Though this is done by GitHub (not me), it is by their design that it has the "wrong" MIME type for this reason.

This is why I'm creating it as a gadget on mediawiki.org so it can be loaded from there (once done you'd load it by doing getScript('..bits.wikimedia.org..mediawiki.org...load.php..modules..gadget.rtrc')