wikimedia / mediawiki-gadgets-RTRC

Mirror of https://gerrit.wikimedia.org/g/mediawiki/gadgets/RTRC.
https://meta.wikimedia.org/wiki/RTRC
MIT License
26 stars 11 forks source link

Turning on 'Hide patrolled edits' breaks RTRC #72

Closed mashedkeyboard closed 7 months ago

mashedkeyboard commented 7 years ago

I get 'Downloading recent changes failed' every time I turn on 'Hide patrolled edits' in RTRC.

See the following examples to reproduce:

With 'Hide patrolled edits' on: https://en.wikipedia.org/wiki/Special:BlankPage/RTRC?opt=%7B%22rc%22%3A%7B%22unpatrolled%22%3Atrue%2C%22typeEdit%22%3Afalse%2C%22namespace%22%3A0%7D%2C%22app%22%3A%7B%22cvnDB%22%3Atrue%7D%7D

Without: https://en.wikipedia.org/wiki/Special:BlankPage/RTRC?opt=%7B%22rc%22%3A%7B%22unpatrolled%22%3Atrue%2C%22typeEdit%22%3Afalse%2C%22namespace%22%3A0%7D%2C%22app%22%3A%7B%22cvnDB%22%3Atrue%7D%7D


package: mw-gadget-rtrc v1.3.3 browser: edge 15.15063 (win)

Krinkle commented 7 years ago

@mashedkeyboard Most likely this is because your user account does not have the patrol right on en.wikipedia.org.

There is however still an issue with RTRC, which is that it is not supposed to show the "HIde patrolled edits" option in your case, and either way, it should show the below warning for you (which it didn't).

code: permissiondenied info: You need the "patrol" or "patrolmarks" right to see distinction between patrolled and unpatrolled edits

Do you see "Hide patrolled edits" option on https://en.wikipedia.org/wiki/Special:Recentchanges? Does it work there?

Cameron11598 commented 5 years ago

@Krinkle I now get the same issue on Commons. Screen shot attached. Side note: I do have the autopatrolled flag on commons. screen shot 2018-11-13 at 11 50 39 am

Arenlor commented 4 years ago

This is still an active issue. https://en.wikipedia.org/wiki/Special:BlankPage/RTRC?opt=%7B%22rc%22%3A%7B%22unpatrolled%22%3Atrue%7D%7D

Krinkle commented 7 months ago

There is no error for me at that link. If this is still an issue, please create a new task at https://phabricator.wikimedia.org/tag/gadget-rtrc/. Thanks!