Closed umherirrender closed 2 years ago
Yeah, you can't disable it inline, I believe. Repo-only for some reason.
It was moved from repo to inline - https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/552949/
Don't see what would be left to do here. Patch shows part inline, part file specific overrides. Seems fair enough.
When updating stylelint-config-wikimedia 0.5.0 to 0.6.0 npm begins to fail on MinervaNeue skin
I have updated grunt-stylelint to 0.14.0 and the issues remains, so I fault the config here, not stylelint
At least the issues in
mediawiki.special.userlogin.common.styles/minerva.less
are disabled, but it seems stylelint just reports the wrong line:column and both lines are not disabled. When moving the disable comment up to the top of the file, it works. But that seems like a bad workaround https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/MinervaNeue/+/3fab70f8bc4ad0603602fb56bd8456a8d7c83ff2/skinStyles/mediawiki.special.userlogin.common.styles/minerva.lessThe issue in
mediawiki.action.history.styles.less
remains https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/MinervaNeue/+/3fab70f8bc4ad0603602fb56bd8456a8d7c83ff2/skinStyles/mediawiki.action.history.styles.lessIt also seems that stylelint cannot show lines with 3 digits (.mw-history-histlinks is in 113 of that file, not 13)