search

wikimedia / stylelint-config-wikimedia

CSS/Less Stylelint configuration according to CSS coding conventions for Wikimedia.
https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS
MIT License
13 stars 8 forks source link

v0.17.0 upgrade fails (ES Module / stylistic) #233

Open Nikerabbit opened 1 month ago

Nikerabbit commented 1 month ago

Warning: Running stylelint failed Error [ERR_REQUIRE_ESM]: require() of ES Module /home/runner/work/mediawiki-extensions-Nimiarkisto/mediawiki-extensions-Nimiarkisto/node_modules/@stylistic/stylelint-plugin/lib/index.js from /home/runner/work/mediawiki-extensions-Nimiarkisto/mediawiki-extensions-Nimiarkisto/node_modules/stylelint/lib/augmentConfig.js not supported. Instead change the require of index.js in /home/runner/work/mediawiki-extensions-Nimiarkisto/mediawiki-extensions-Nimiarkisto/node_modules/stylelint/lib/augmentConfig.js to a dynamic import() which is available in all CommonJS modules.

Nikerabbit commented 1 month ago

E.g. https://github.com/Nikerabbit/mediawiki-extensions-Termbank/actions/runs/9372769164/job/25804975326?pr=31 or https://github.com/Nikerabbit/mediawiki-extensions-Nimiarkisto/actions/runs/9356214885/job/25753137221?pr=38

supertassu commented 1 month ago

This sounds like you're upgrading stylelint-config-wikimedia but not grunt-stylelint at the same time.

Nikerabbit commented 1 month ago

Is this documented somewhere? I saw nothing in release notes and both upgrades (as the bot is not combining updates) are failing separately, so it's not very intuitive.

jdforrester commented 1 month ago

Is this documented somewhere? I saw nothing in release notes and both upgrades (as the bot is not combining updates) are failing separately, so it's not very intuitive.

When you try to upgrade one without the other, npm will alert you with incompatible dependencies. The same as happened for #231. Is your npm not giving you these warnings?

Nikerabbit commented 1 month ago

No, I am not seeing any warnings about incompatible dependencies.