search

wikimedia / stylelint-config-wikimedia

CSS/Less Stylelint configuration according to CSS coding conventions for Wikimedia.
https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS
MIT License
14 stars 9 forks source link

Give an rationale for why we enforce certain property values, using `message` property. #30

Open Volker-E opened 8 years ago

Volker-E commented 8 years ago

Should we provide comments in index.js on certain property values? The "stylelint-value-border-zero" plugin returned

Line 292, column 3: 'border: 0' is preferred over 'border: none' (value-border-zero) (error)

while declaration-property-value-blacklist offers following error

292:3 ✖ Unexpected value "none" for property "border" declaration-property-value-blacklist

It could be a bit more insightful. The blacklist rule doesn't provide option to customize output. So I think providing guidance in comments/links to guiding principles would be useful…

edg2s commented 8 years ago

The json format doesn't support comments which would make this harder to do.

Volker-E commented 8 years ago

The file features .js extension so far (actually wanted to write index.js in the issue title), so it would be more easily possible as long as we stick with JS.

Volker-E commented 5 years ago

See also https://github.com/wikimedia/stylelint-config-wikimedia/issues/89#issuecomment-503624507. message would provide fine-tailored feedback to devs.