Simplify reader interactions

wikimedia / wikipedia-preview

https://wikimedia.github.io/wikipedia-preview/main

MIT License

64 stars 23 forks source link

Simplify reader interactions #210

Closed medied closed 3 months ago

medied commented 4 months ago

https://phabricator.wikimedia.org/T360752

Demo: https://wikimedia.github.io/wikipedia-preview/T360752-reader-interactions/

Adds a scroll cue (fade) without adding event listeners
Removes a bunch of code related to onExpand and simplifies the reader interaction
Updates Storybook and tests accordingly

[x] leave gallery row
[x] fix cypress tests
[x] update storybook
[x] update README screenshots

hueitan commented 4 months ago

first time when you hover a disambiguation text (cue is available)	second time it works fine but showing console error

medied commented 4 months ago

Good catch Huei, I've updated to address your feedback. Note the code flow related to the gallery will likely be further updated when we work on https://phabricator.wikimedia.org/T360753