search

wikipathways / GPML2RDF

GPML2RDF converter
Apache License 2.0
4 stars 2 forks source link

Support of Complex identifiers #75

Open egonw opened 4 years ago

egonw commented 4 years ago

During the #covidpathways project, we worked on one solution to support complex identifiers. Ideally, the Complex groups have identifiers themselves, but until then, this my be a solution. See this patch: https://github.com/wikipathways/GPML2RDF/commit/193d015c18d72d812a51865d17a6787d39a69dfe

THIS IS AN ONGOING DISCUSSION.

egonw commented 4 years ago

cc @DeniseSl22

DeniseSl22 commented 4 years ago

This would also need to be implemented in PV + GPML, I suppose?

egonw commented 4 years ago

Yes, but it currently is not. The trick used right now is as follows: each GPML Complex with (exactly) one DataNode of @Type="Complex" with an identifier inherits the identifiers from that DataNode.

That's in the RDF. Because of the extra DataNode with identifier, that works with existing approaches. Check WP4846 for examples.

DeniseSl22 commented 4 years ago

Okay, that sounds clever.... updating the GPML to accommodate for this is much more work indeed (but that's probably for the future, because I think we want to build complexes with more then 1 DataNode ;) ).