search

wikipathways / WpVocabularies

WikiPathways vocabularies for RDF representation
https://vocabularies.wikipathways.org/
Apache License 2.0
1 stars 3 forks source link

Meanings of Width and Height #16

Open ariutta opened 6 years ago

ariutta commented 6 years ago

I'm proposing we explicitly define GPML Width and Height to be actual width and height. See this issue for more details. Sound OK?

AlexanderPico commented 6 years ago

Hmm... The current way is how other tools do it as well, e.g., Cytoscape. I'd be concerned that if we change this, then all other tools that visualize GPML will be "off" a bit, unless they change too.

My first question is why change this at all? What is the bug or issue caused by the current definition of width and height?

ariutta commented 6 years ago

The thing is that there is no current definition. There's only the subjective visual inspection of what PathVisio-Java does, and that varies depending on zoom level.

AlexanderPico commented 6 years ago

Ok. So we explicitly define GPML width and height as "the actual width and height", without specifying inner, outer, mid, etc... because those vary on zoom level? This means no change to how width and height are actually parsed and rendered in our current tools? That's fine with me.

AlexanderPico commented 6 years ago

Or, do you mean, let's explicitly define GPML width and height as "the outer width and height" (like described here) and it just turns out that PathVisio-Java is wrong sometimes, but nothing changes in the code in terms of parsing and rendering?

I'm also fine this with! :)

ariutta commented 6 years ago

Yes, the latter.