search

wikipathways / cytoscape-wikipathways-app

WikiPathways app for Cytoscape to open and access pathways from WikiPathways
Apache License 2.0
5 stars 7 forks source link

Some group styles are not visualized correctly #55

Closed khanspers closed 6 years ago

khanspers commented 6 years ago

Group style "none" (beige rectangle with dashed border) and "pathway" (green rectangle) are not visualized correctly. They both resemble the "complex" type of group. Note that groups of type "complex" and "group" are visualized correctly.

See attached, with labels explaining what the groups are assigned to. Second screenshot is from WP.

screen shot 2017-09-28 at 12 54 24 pm screen shot 2017-09-28 at 1 12 30 pm
khanspers commented 6 years ago

screen shot 2017-10-02 at 3 50 14 pm

Representation of what all four group styles look like in PathVisio (and WP), the label above each is that the style is called in gpml, i.e. "Style="Complex" etc.

AdamStuart commented 6 years ago

DelayedVizProp #250 is where the code starts

AlexanderPico commented 6 years ago

https://github.com/wikipathways/cytoscape-wikipathways-app/blob/develop/src/main/java/org/wikipathways/cytoscapeapp/impl/DelayedVizProp.java#L250

AlexanderPico commented 6 years ago

Relevant code also here: https://github.com/wikipathways/cytoscape-wikipathways-app/blob/develop/src/main/java/org/wikipathways/cytoscapeapp/impl/GpmlToPathway.java

AlexanderPico commented 6 years ago
screen shot 2017-11-04 at 5 04 56 pm