search

wikipathways / cytoscape-wikipathways-app

WikiPathways app for Cytoscape to open and access pathways from WikiPathways
Apache License 2.0
5 stars 7 forks source link

Error when opening pathway #56

Closed khanspers closed 6 years ago

khanspers commented 6 years ago

Got this error with two different pathways (Human Statin and Human Apoptosis), when importing either as network or pathway. The pathway still loads and a view is create.

Maybe related to https://github.com/wikipathways/cytoscape-wikipathways-app/issues/49 screen shot 2017-10-18 at 2 02 45 pm

AlexanderPico commented 6 years ago

Ok. Tracked this one down... sort of.

I tested multiple versions of the app over the past 6 months and they all now trigger this error (when they definitely didn't before). So, then I started testing older builds of Cytoscape. I have a 3.6.0 from Sept 22nd and it does NOT have this error!

The error is definitely in Cytoscape core code and it was due to a change between 9/22 and 10/18.

AlexanderPico commented 6 years ago

Ok. I think I found it...

https://github.com/cytoscape/cytoscape-impl/blob/develop/core-task-impl/src/main/java/org/cytoscape/task/internal/view/CreateNetworkViewTask.java#L219

This was checked in last week. Adam, do you want to try modifying this and retesting?

AdamStuart commented 6 years ago

resolved with Alex's fix