Group styles are not always displayed

wikipathways / pvjs

JavaScript-based pathway viewer and editor

Apache License 2.0

33 stars 19 forks source link

Group styles are not always displayed #425

Closed khanspers closed 6 years ago

khanspers commented 6 years ago

Groups styles (complex, pathway, none) are not always displayed the same as what shows on the main site. Looks like it is related to pathways specifically using 2013a schema. Is this not supported in the new viewer?

Problem pathways: http://dev.wikipathways.org/index.php/Pathway:WP4 http://dev.wikipathways.org/index.php/Pathway:WP2636 http://dev.wikipathways.org/index.php/Pathway:WP1403

Pathways that are ok: http://dev.wikipathways.org/index.php/Pathway:WP78 http://dev.wikipathways.org/index.php/Pathway:WP528

AlexanderPico commented 6 years ago

Confirming this is still an issue. Specifically, notice how the complex borders are missing in this pathway and the complex name labels are displayed in the center.

http://dev.wikipathways.org/index.php/Pathway:WP2636 https://www.wikipathways.org/index.php/Pathway:WP2636

screen shot 2017-12-06 at 5 16 49 pm

ariutta commented 6 years ago

This commit was needed for Complex shape to show.

khanspers commented 6 years ago

WP4 on dev site still shows the group styles incorrectly.

The top left group is style "none" and should be a dashed outline beige rectangle
The mitochondria is in a group with style "pathway" so should be in a green rectangle with dashed outline. Looks like style Complex is fixed though.

http://dev.wikipathways.org/index.php/Pathway:WP4 https://www.wikipathways.org/index.php/Pathway:WP4

AlexanderPico commented 6 years ago

I agree on the group with style "none", but I don't understand of the use of the pathway group. Do we have any real cases of how this is used and should be rendered?

khanspers commented 6 years ago

Right, the pathway style is almost never used. I found one occurence (did grep on Oct download for all species), and actually in this case it renders just fine: http://dev.wikipathways.org/index.php/Pathway:WP3670

AlexanderPico commented 6 years ago

Ah, then it not a bug :) I tried to update WP4 on dev and broke it somehow... Sorry!

Do we have any real examples of the group "none"?

khanspers commented 6 years ago

Don't know off hand of real examples of group style none, and can't d a grep for a it because they way its defined is simply without the "style=" parameter, so nothing to search for......

AlexanderPico commented 6 years ago

Here's one: http://dev.wikipathways.org/index.php/Pathway:WP1539

They are rendered properly...

I think the sandbox pathway is an exception for some reason...