search

wikipathways / rWikiPathways

R package for WikiPathways API
https://r.wikipathways.org/
MIT License
15 stars 6 forks source link

`getColoredPathway` should recognize if the remote API method is offline #9

Closed egonw closed 4 years ago

egonw commented 5 years ago

@AlexanderPico, the alternative is, of course, the remove the method altogether.

egonw commented 5 years ago

@AlexanderPico, I have patches to address this in this PR: https://github.com/egonw/rWikiPathways/pull/11

If you are happy with the patches, I will prepare a proper pull request. After that, I also will want to backport this to the current stable release, as I think both can be considered bug fixes.

egonw commented 5 years ago

(I found this issue when working on https://github.com/wikipathways/rWikiPathways/issues/8)

AlexanderPico commented 5 years ago

Yes, if you can provide a patch against the master, then I can handle pushing it to dev and current release branches here and upstream (i.e., bioconductor).

AlexanderPico commented 4 years ago

deprecated in 1.8.0 release