Authors are not displayed consistently

[AlexanderPico]

If I refresh this page, I sometimes see the author list (below the pathway, just above the description) and sometime not. Maybe ~ 50% of the time?

https://vm1.wikipathways.org/Pathway:WP554

Odd bug.

In general, I don't mind the new placement of the author list above the description. Kind of looks like authors and an abstract. But we might want to get more feedback on whether some people think this "devalues" contributors...

[AlexanderPico]

This error shows up in console when author list is not displayed:

Exception in module-execute in module wpi.AuthorInfo: load.php:176:15 TypeError: AuthorInfo is undefined TypeError columnNumber: 650 fileName: "https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=ext.biblioPlus.qtip%7Cext.biblioPlus.qtip.config%7Cjquery.accessKeyLabel%2CbyteLength%2CcheckboxShiftClick%2Cclient%2Ccookie%2CgetAttrs%2ChighlightText%2Cmw-jump%2Csuggestions%2CtabIndex%2Ctablesorter%2Cthrottle-debounce%7Cmediawiki.RegExp%2CTitle%2Capi%2Ccldr%2Ccookie%2CjqueryMsg%2Clanguage%2Cnotify%2CsearchSuggest%2Cstorage%2Ctemplate%2Cuser%2Cutil%7Cmediawiki.action.view.postEdit%7Cmediawiki.api.user%2Cwatch%7Cmediawiki.language.data%2Cinit%2Cmonths%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%2Cstartup%7Cmediawiki.page.watch.ajax%7Csite%7Cskins.vector.js%7Cuser.defaults%7Cwpi.AuthorInfo%2CPathway&skin=vector&version=0hyf7lm" lineNumber: 147 message: "AuthorInfo is undefined" stack: "@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=ext.biblioPlus.qtip%7Cext.biblioPlus.qtip.config%7Cjquery.accessKeyLabel%2CbyteLength%2CcheckboxShiftClick%2Cclient%2Ccookie%2CgetAttrs%2ChighlightText%2Cmw-jump%2Csuggestions%2CtabIndex%2Ctablesorter%2Cthrottle-debounce%7Cmediawiki.RegExp%2CTitle%2Capi%2Ccldr%2Ccookie%2CjqueryMsg%2Clanguage%2Cnotify%2CsearchSuggest%2Cstorage%2Ctemplate%2Cuser%2Cutil%7Cmediawiki.action.view.postEdit%7Cmediawiki.api.user%2Cwatch%7Cmediawiki.language.data%2Cinit%2Cmonths%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%2Cstartup%7Cmediawiki.page.watch.ajax%7Csite%7Cskins.vector.js%7Cuser.defaults%7Cwpi.AuthorInfo%2CPathway&skin=vector&version=0hyf7lm:147:650\nfire@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:45:104\nadd@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:45:656\njQuery.fn.ready@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:49:40\n@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=ext.biblioPlus.qtip%7Cext.biblioPlus.qtip.config%7Cjquery.accessKeyLabel%2CbyteLength%2CcheckboxShiftClick%2Cclient%2Ccookie%2CgetAttrs%2ChighlightText%2Cmw-jump%2Csuggestions%2CtabIndex%2Ctablesorter%2Cthrottle-debounce%7Cmediawiki.RegExp%2CTitle%2Capi%2Ccldr%2Ccookie%2CjqueryMsg%2Clanguage%2Cnotify%2CsearchSuggest%2Cstorage%2Ctemplate%2Cuser%2Cutil%7Cmediawiki.action.view.postEdit%7Cmediawiki.api.user%2Cwatch%7Cmediawiki.language.data%2Cinit%2Cmonths%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%2Cstartup%7Cmediawiki.page.watch.ajax%7Csite%7Cskins.vector.js%7Cuser.defaults%7Cwpi.AuthorInfo%2CPathway&skin=vector&version=0hyf7lm:147:621\nrunScript/<@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:161:89\nfire@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:45:104\nadd@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:45:656\nalways@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:46:865\nrunScript@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:160:944\ncheckCssHandles@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:161:678\ncssHandle/<@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:161:808\nfire@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:45:104\nfireWith@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:46:431\nfire@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:46:474\nfireCallbacks@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:156:320\naddEmbeddedCSS@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:156:661\naddEmbeddedCSS/cssBufferTimer<@https://vm1.wikipathways.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1eyf2vn:156:538\n" proto: Object { stack: "", … }

[hexmode]

What do you think of placing the authors in the initial output of the page rather than adding it later with js?

[AlexanderPico]

IIRC, the js processing is needed to get the author order right. Are you proposing that we do that calculation earlier (e.g., at page save) and store it as a ready-to-go string in the database to be placed during the initial output of the page?

[hexmode]

Just that it is done earlier. I could see it happening at page save time. I'll look at the calls being made to determine what would need to happen.

[hexmode]

Oh, and they should definitely display on top. That they aren't is easily fixed.

[hexmode]

See this commit for the position fix: wikipathways/mediawiki-extensions-WikiPathways-GPML@4cfdc048288a204ab2fb3c9ec78e51de9271f2f3

[hexmode]

Just saw the following Exception in module-execute in module wpi.AuthorInfo: TypeError: AuthorInfo is undefined