Closed bricehalder closed 2 years ago
Mostly writing down for future-me:
This leads itself to a discussion on a re-write of the start-of-game logic. My initial hunch is that we need to change the way we integrate countdown.js
into play.js
so that we can avoid doing the async start()
altogether, since that is called through some very weird Vue mechanic through $emit('start-game')
. I think most of the logic should be in mounted()
or on the first pageCallback()
in play.js
Seems like we are seeing some large negative times on the leaderboard. Opening issue to investigate.
From these results, we can see that we have 4 distinct cases here:
Case 1: looks like overflow, negative times from large
timeReached
on first article Case 2: still large, negative times, butpath
json looks good. Not sure what the cause is here Case 3: small negative times,timeReached
still looks like large overflow Case 4: small negative times,timeReached
is very smallCases 3 and 4 are only exhibited for unfinished runs.
My current suspicion is that values are not being initialized correctly, at least for Case 1.
This could be related to #392, but seems distinct enough that making a separate issue here (we can merge if they end up being the same).