search

wikispeedruns / wikipedia-speedruns

Source code for Wikipedia Speedruns!
https://wikispeedruns.com
MIT License
100 stars 30 forks source link

Delete lobby #517

Closed kwonghua closed 11 months ago

kwonghua commented 1 year ago

added functionality to delete lobby from lobby page

bricehalder commented 12 months ago

Good start, also would be good to upload screenshot or better a video to show usage / testing the change

kwonghua commented 11 months ago

I made some changes based on the comments above.

As for handling the deletion of lobbies, I went with the recommended approach and added a isHidden column in the lobbys table.
However with that we would need to run when merging to prod: ALTER TABLE lobbys ADD isHidden BOOLEAN DEFAULT 0;

Currently there is a minor issue in the case of if all lobbies are marked as hidden then on the home page in the lobby section under Party Mode, the default message You don’t have any existing lobbies. will not display.

bricehalder commented 11 months ago

LGTM, @dqian3 for merging to prod

dqian3 commented 11 months ago

Merged and updated database as described. Feel free to tackle the hidden lobby bug later @kwonghua, just glancing at it I think you'd need to do the filtering the the Javascript, not just the html.