wikispeedruns / wikipedia-speedruns

Source code for Wikipedia Speedruns!
https://wikispeedruns.com
MIT License
96 stars 27 forks source link

Add dark mode #528

Closed Resonantjacket5 closed 10 months ago

Resonantjacket5 commented 10 months ago

Changes

Other notes

bricehalder commented 10 months ago

This is epic!! Thanks for this awesome effort. Can you upload screenshots or a video to show its usage?

Resonantjacket5 commented 10 months ago

Had to lower quality and trim to fit 10 megabyte limit.

https://github.com/wikispeedruns/wikipedia-speedruns/assets/5826282/61a7623e-0e48-42d3-925f-0ba77f385061

https://github.com/wikispeedruns/wikipedia-speedruns/assets/5826282/1d169eb6-c8f5-4efa-bd7d-577e63081686

dqian3 commented 10 months ago

Dang, this is what happens when someone who knows what they're doing with CSS looks at our site lol. Will merge with the batch of other changes!

Resonantjacket5 commented 10 months ago

Ohhhh I see we’ve changed the delimiters from the {{}} to [[]]. :)

I thought it was jinga messing it up even after adding escape characters.

dqian3 commented 10 months ago

Ohhhh I see we’ve changed the delimiters from the {{}} to [[]]. :)

I thought it was jinga messing it up even after adding escape characters.

Oh yeah, you're actually right that it was jinja, with our weird setup of flask serving vue templates, {{}} were used by both jinja and vue, and so conflicted. So we changed the vue delimiter to [[]]

dqian3 commented 10 months ago

@bricehalder @mliu59 Could one of you go through and check if there's any other custom components that we missed. I think it should be good

bricehalder commented 10 months ago

I think it looks good enough, if there's anything we missed we can address it in future PRs

mliu59 commented 10 months ago

merge merge merge