search

wikispeedruns / wikipedia-speedruns

Source code for Wikipedia Speedruns!
https://wikispeedruns.com
MIT License
100 stars 30 forks source link

Added arrows to path #530

Closed imvbh closed 10 months ago

imvbh commented 12 months ago

Change: Removed the list type output[ quotes(") and commas(,)] on the results page and added arrow→ to represent a flow. This fixes #529

imvbh commented 12 months ago

@bricehalder could you review this one please?

mliu59 commented 12 months ago

@imvbh Thanks for putting in this PR! I'm wondering if there's a different symbol we can use instead of arrows to delimit the starting checkpoints. Users can go to any checkpoint in any order, so we don't want to give them the idea that they can only go in a specific order.

imvbh commented 11 months ago

@mliu59 I don't think I am getting what you exactly mean? Especially, by user going to any checkpoint i order. Isn't it like a linear flow? Can you give some example ?

dqian3 commented 11 months ago

@imvbh I'm not sure what this is supposed to do? The leaderboard already displays the paths using arrows. This function is some internal thing that seems like it doesn't really get used.

If you want to change the share path output, that would be here: play_finish.js. However, I don't know if we would want to make the share format with arrows.

mliu59 commented 11 months ago

@imvbh My bad, I misread the filename you edited. The checkpoint list that @bricehalder was referring to was for the marathon list module on the home page, implemented in static/js/modules/game/marathon/marathonPrompts.js.

dqian3 commented 10 months ago

Closing for inactivity.