search

wikispeedruns / wikipedia-speedruns

Source code for Wikipedia Speedruns!
https://wikispeedruns.com
MIT License
101 stars 30 forks source link

QR code to lobby page #600

Open bricehalder opened 3 months ago

bricehalder commented 3 months ago

Especially for IRL events, a dropdown/button to display a QR code on the lobby page can help people open the lobby on their phones

MarekSabol commented 1 month ago

Hi is this still available ? I would like to take over

MarekSabol commented 1 month ago

@bricehalder Hi I wanted to ask if this is still available if you can maybe assign it to me

bricehalder commented 1 month ago

@bricehalder Hi I wanted to ask if this is still available if you can maybe assign it to me

@MarekSabol Sure! Feel free to ask any questions here or in our discord

RolandSmarzik commented 1 month ago

Hi I discussed with @MarekSabol and I would like to take over this issue instead of him, he should also add a comment in the close future regarding this topic.

MarekSabol commented 1 month ago

@RolandSmarzik feel free to take over, I took over other issues. Thanks

RolandSmarzik commented 1 month ago

Hi @bricehalder Regarding this issue my proposed realisation would be the modification of lobby.js and lobby.html with the usage of QRCode.js library, the confusing part for me right now is the place where I should add the import of the library for front end, for now I tried to make a demo implementation with the import being in the html and it works fine, but let me know if you had something different in mind for this issue so I can adjust my PR :). Best regards Roland.

bricehalder commented 1 month ago

Hey @RolandSmarzik, thanks for working on this! If you can attach a pull request / draft PR to this issue we can take a look

RolandSmarzik commented 3 weeks ago

Hi @bricehalder please see pull request #614, thank you. Best Regards, Roland