search

wikispeedruns / wikipedia-speedruns

Source code for Wikipedia Speedruns!
https://wikispeedruns.com
MIT License
100 stars 30 forks source link

Links containing '#' break the game #601

Closed bricehalder closed 4 weeks ago

bricehalder commented 2 months ago

At least 2 users have reported that links containing '#' break the game

Hi! I'm playing today's prompt and there is a page that links to the target article but there is no response when I click it. It has "#" in the link. Is there any way around this? https://discord.com/channels/936202186520678431/936212632866783333/1277838679393435753

This is a known issue (for me). Links containing # do not work and break the app. I have learned never to click on one of those. https://discord.com/channels/936202186520678431/936212632866783333/1277891965979070484

Potential fixes: 1) remove hyperlink if link contains '#' 2) (preferred) trim hyperlink to remove '#' and anything after - i.e. still navigate to desired page

Resonantjacket5 commented 4 weeks ago

Inspected the issue briefly, while the link is redirected correctly it seems there's an issue with the client code with handling # urls

https://wikispeedruns.com/wiki/Kjula_Runestone#S%C3%B6_106
Screenshot 2024-10-20 at 5 22 29 PM
Resonantjacket5 commented 4 weeks ago

Nvm someone is already working and proposed a fix https://github.com/wikispeedruns/wikipedia-speedruns/pull/608/files