wikitongues / poly

Open source, modern software to share and learn every language in the world.
https://poly.wikitongues.org
GNU General Public License v3.0
80 stars 19 forks source link

Remove unused language table from schema #288

Closed AmrAdelKhalil closed 6 years ago

AmrAdelKhalil commented 6 years ago

@FredericoAndrade Removing Language table from the schema.

FredericoAndrade commented 6 years ago

@AmrAdelKhalil usually, its not a good idea to make direct changes to the schema, opting instead to commit migrations. This way you have a good, clear way to track all the changes, and avoid breaking the schema and potentially the database (Bad!). I'll take care of fixing this PR and merging it in :)

AmrAdelKhalil commented 6 years ago

@FredericoAndrade Hey, I was about to make a migration to remove language table but when i looked the whole migrations i didn't find the one that creates language table so i had two options: 1- make two migrations: 1.1- Migration creates language table 1.2- Migration remove it. 2- Just remove it directly from schema file.

I though rails would through an exception when it try to remove a table that doesn't exists.