fix gymfc-continous-v1 bug

wil3 / gymfc

A universal flight control tuning framework

http://wfk.io/neuroflight/

MIT License

389 stars 99 forks source link

fix gymfc-continous-v1 bug #99

Closed Suvian-wy closed 3 years ago

Suvian-wy commented 3 years ago

Requirements for Pull Request

Read CONTRIBUTING.md.
Open an issue. Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Fill out the template below, any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

Description of the Change

Closes: #XXX

Verification Process

wil3 commented 3 years ago

Hi @Suvian-wy please fill out the template above. Did you read CONTRIBUTING.md? Good documentation helps to improve the project and allow others to understand the changes that are made.

Suvian-wy commented 3 years ago

Requirements for Pull Request

Read CONTRIBUTING.md.

Open an issue. Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Fill out the template below, any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

Description of the Change

Fix: Change occur in the continous.py.

Correct the parent class of class ContinuousEnv.

update the function name in class ContinuousEnv.

Verification Process

Has been verified. Tested by running test by run python ppo_baselines_train.py --gym-id gymfc_nf-continuous-v1. No error.

wil3 commented 3 years ago

Please limit the scope of this PR to just fixing the import bug. Your other changes introduce other issues. I see this PR is from your master branch and probably why its pulling in other changes than just the bug fix. Recommended in the future to create a separate branch as documented in CONTRIBUTING.md.