search

wil3 / neuroflight

Next Generation Flight Controller Firmware
https://wfk.io/neuroflight/
GNU General Public License v3.0
226 stars 45 forks source link

Update README.md #1

Closed auturgy closed 5 years ago

auturgy commented 5 years ago

Apologies for doing it this way, but you have “issues” disabled. Can you make a compiled firmware available please? I have a quad suitable to give this a go, but it’s a complex build chain. If you could provide firmware for a couple of F7 boards I think you could get some useful feedback. Perhaps KakuteF7 and Omnibus F7 v2? They use an F745, which has twice the flash of the F722 (how you squeezed a 913kb firmware onto a board with 512kb flash I’d love to know. I’m guessing there’s a typo in your report?).

Important considerations when opening a pull request:

  1. Pull requests will only be accepted if they are opened against the master branch. Pull requests opened against other branches without prior consent from the maintainers will be closed;

  2. Please follow the coding style guidlines: https://github.com/cleanflight/cleanflight/blob/master/docs/development/CodingStyle.md

  3. Keep your pull requests as small and concise as possible. One pull request should only ever add / update one feature. If the change that you are proposing has a wider scope, consider splitting it over multiple pull requests. In particular, pull requests that combine changes to features and one or more new targets are not acceptable.

  4. Ideally, a pull request should contain only one commit, with a descriptive message. If your changes use more than one commit, rebase / squash them into one commit before submitting a pull request. If you need to amend your pull request, make sure that the additional commit has a descriptive message, or - even better - use git commit --amend to amend your original commit.

  5. All pull requests are reviewed. Be ready to receive constructive criticism, and to learn and improve your coding style. Also, be ready to clarify anything that isn't already sufficiently explained in the code and text of the pull request, and to defend your ideas.

  6. If your pull request is a fix for one or more issues that are open in GitHub, add a comment to your pull request, and add the issue numbers of the issues that are fixed in the form Fixes #<issue number>. This will cause the issues to be closed when the pull request is merged;

  7. Remove this Text :).

wil3 commented 5 years ago

Hey @auturgy thanks for pointing that out, it must have been inherited by the maintenance fork of betaflight, its fixed now. This is an experimental project used as a research platform and in active development. At this time there is no plan to release pre-compiled firmware images as the controller needs to be trained for an individual aircraft. We are currently researching and experimenting with methods to generate generic controllers. When the time comes we will probably open a beta program to get feedback.

Hex images contains extra information such as where the data should be placed that is not flashed to the microcontroller. The neuroflight firmware image for the Matek F722 is comparable in size to that of Betaflight (896K).