wilas / vbkick

Tool for building and maintaining VirtualBox VMs described as a code in a single definition file.
Other
8 stars 5 forks source link

vbkick should allow choose hashing algorithms - md5,sha256,etc #10

Closed wilas closed 11 years ago

wilas commented 11 years ago

replace boot_file_src_sha256 option by boot_file_checksum_cmd + boot_file_src_checksum. It should allow use other checksum commands and cryptographic algorithms.

wilas commented 11 years ago

md5sum will be the default command.

alanpearce commented 11 years ago

Hmm, md5sum doesn't exist on FreeBSD or OSX. I also think that SHA256 is a better algorithm to use anyway.

wilas commented 11 years ago

MD5 is more popular, e.g. SmartOS not provide SHA256. For a file as big as ISO image there is no different which algorithm is used, both are enough good.

wilas commented 11 years ago

I think that boot_file_checksum_cmd made definitions less portable, because inside definitions you have to deal which cmd use. Much better is replace boot_file_checksum_cmd by boot_file_checksum_type and inside vbkick check available md5 or sha256 commands.