wilas / vbkick

Tool for building and maintaining VirtualBox VMs described as a code in a single definition file.
Other
8 stars 5 forks source link

Enhancement: Improve BASH_SHEBANG and PY_SHEBANG handling #14

Closed alanpearce closed 10 years ago

alanpearce commented 10 years ago

I think it might be nice if the Makefile would try to detect the location of bash and python before using them. Alternatively it could just check if they exist and throw an error, so that the user doesn't end up with a broken build.

On FreeBSD, the build command has to be like this: sudo sh -c 'BASH_SHEBANG=which bashPY_SHEBANG=which pythongmake install', which is quite tedious.

wilas commented 10 years ago

I agree. if BASH_SHEBANG and/or PY_SHEBANG is not defined then Makefile should detect the location, if bash or python won't be found then an error message. If shebang are defined by user then check is not needed as shebang may look like /usr/bin/env python.

wilas commented 10 years ago

@alanpearce do you want work on this issue or do you want me to do this ? Just to avoid concurrent work :)

alanpearce commented 10 years ago

I'm not too familar with makefiles, so it'll probably be easier for you to do it, if that's okay :)

wilas commented 10 years ago

Sure :)